Fix partitioning root UUID bug in /etc/crypttab. New option: CRYPTROOT_MAPPER. #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/small
Thank you! It would be ❤️ helpful adding this to the documentation, above this https://docs.armbian.com/Developer-Guide_Build-Options/#build-options-below-need-to-be-retested-and-added-above-could-be-deprecated |
igorpecovnik
added
Ready to merge
igorpecovnik
approved these changes
Nov 5, 2024
|
|
Is slightly improved (and hopefully correctly placed) https://docs.armbian.com/Developer-Guide_Build-Switches/#filesystem still ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix partitioning root UUID bug in /etc/crypttab.
New option: CRYPTROOT_MAPPER. Make ROOT_MAPPER name for CRYPTROOT changable.
How Has This Been Tested?
How To Repoduce
./compile.sh build CRYPTROOT_ENABLE=yes CRYPTROOT_PASSPHRASE="toor" CRYPTROOT_SSH_UNLOCK=yessudo losetup --show --partscan --find Armbian-unofficial_*-crypt.imgsudo blkid /dev/loop*rootdev=/dev/mapper/armbian-root cryptdevice=UUID=${UUID}:armbian-root) not exists in blkid output