Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radxa Rock-3a - edge - add GPIO names #7403

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

mr-toolcraft
Copy link
Contributor

Description

Shoutout to kwiboo and twoerner. I used their patch for the Zero 3W/E as template for this one....except their formatting was cleaner than mine.

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Oct 23, 2024
@EvilOlaf
Copy link
Member

Man I need to get my token with me by chance so I don't have to rely on 2nd account remotely lol

@EvilOlaf EvilOlaf requested a review from a team October 26, 2024 07:25
Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool to me 👍

@ColorfulRhino ColorfulRhino added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Oct 27, 2024
@igorpecovnik igorpecovnik merged commit ac1b273 into armbian:main Oct 28, 2024
3 checks passed
@igorpecovnik
Copy link
Member

igorpecovnik commented Oct 28, 2024

this needs some adjustments.
https://paste.armbian.de/cufizecupo

@mr-toolcraft
Copy link
Contributor Author

mr-toolcraft commented Oct 29, 2024

Hm no clue. I recreated the patch from scratch but besides the date nothing changed. Applies clean for me...
https://paste.armbian.com/orozelusiz

@igorpecovnik
Copy link
Member

probably other patches were added here ... did you try this from main branch without changes?

@mr-toolcraft
Copy link
Contributor Author

Yeah pulled beforehand. The files differing from main are mentioned in the logs

@igorpecovnik
Copy link
Member

are mentioned in the logs

I am on the road and can only revert changes.

@mr-toolcraft
Copy link
Contributor Author

Then revert for now. No clue

@igorpecovnik
Copy link
Member

Consequence of fixing this is drinking a cold coffee ;) #7417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

4 participants