Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radxa rock-3a - edge - add overlay to disable debug console #7402

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

mr-toolcraft
Copy link
Contributor

Description

This adds a small overlay to allow the debug serial console being disabled. This will make two additional GPIO pins available for other purpose. Some people may need the additional I/O for whatever reason.

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

  • compile .dtso file using dtc
  • enable and reboot: serial console is disabled
  • compile ./compile.sh kernel BOARD=rock-3a BRANCH=edge KERNEL_CONFIGURE=no

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Oct 23, 2024
@mr-toolcraft mr-toolcraft changed the title rock-3a: add overlay to disable debug console Radxa rock-3a - edge - add overlay to disable debug console Oct 23, 2024
@SuperKali SuperKali added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Oct 23, 2024
@EvilOlaf
Copy link
Member

EvilOlaf commented Oct 23, 2024

I don't think this needs much of a review. Overlay is disabled by default and I assume it'll be rarely used at all.

Though I won't approve my own stuff.

@igorpecovnik igorpecovnik merged commit a8e7d17 into armbian:main Oct 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

5 participants