Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation: armbian-kernel: Change forced uncompressed modules option for kernels >=v6.12 #7389

Merged
merged 1 commit into from
Oct 20, 2024
Merged

compilation: armbian-kernel: Change forced uncompressed modules option for kernels >=v6.12 #7389

merged 1 commit into from
Oct 20, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

@ColorfulRhino ColorfulRhino commented Oct 18, 2024 •
edited
Loading

Description

When building rk3588-edge v6.12, the build script nicely outputs the following warning:

[🚸] Forced kernel options introduced misconfigurations or missing dependencies! [ Please re-run rewrite-kernel-config ]
[🚸] If this warning persists after re-run [ please remove dependent options using kernel-config or adapt your custom_kernel_config hooks ]
[🔨]   -MODULE_COMPRESS_NONE y
[🚸] See options above which have been changed automatically [ to solve dependencies and/or misconfigurations ]

The kernel option CONFIG_MODULE_COMPRESS_NONE was superseded by CONFIG_MODULE_COMPRESS in 6.12 (source: torvalds/linux@c7ff693). Adapt the kernel compilation script accordingly to force the correct kernel option.

Yes, I do know that CONFIG_MODULE_COMPRESS was also used pre-6.0, but that was a slightly different config option, so I left the if-else as is for future reference and better visibilty.

How Has This Been Tested?

  • Build warning on compiling rk3588-edge v6.12 disappears

Checklist:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@ColorfulRhino ColorfulRhino requested a review from a team as a code owner October 18, 2024 12:30
@github-actions github-actions bot added the size/small PR with less then 50 lines label Oct 18, 2024
@ColorfulRhino ColorfulRhino added 11 Milestone: Fourth quarter release and removed size/small PR with less then 50 lines labels Oct 18, 2024
@github-actions github-actions bot added the Framework Framework components label Oct 18, 2024
@ColorfulRhino
compilation: armbian-kernel: Change forced uncompressed modules optio…
5e23c0a 
…n for kernels >=v6.12

The kernel option `CONFIG_MODULE_COMPRESS_NONE`  was superseded by `CONFIG_MODULE_COMPRESS` in 6.12.
Adapt the kernel compilation script accordingly to force the correct kernel option.

Source: torvalds/linux@c7ff693
@github-actions github-actions bot added the size/small PR with less then 50 lines label Oct 18, 2024
rpardini
rpardini approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ColorfulRhino
Copy link
Collaborator Author

Nice!

Yeah, I'm glad implementing this misconfiguration check some months ago wasn't completely useless 😄
This is a candidate to add to automated testing at some point in the future as well.

@ColorfulRhino ColorfulRhino added the Ready to merge Reviewed, tested and ready for merge label Oct 20, 2024
@igorpecovnik igorpecovnik merged commit 82aa7b3 into armbian:main Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpardini rpardini rpardini approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColorfulRhino @rpardini @igorpecovnik