Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Update MOTD to include IPv6 local addresses #7315

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Improvement: Update MOTD to include IPv6 local addresses #7315

merged 3 commits into from
Oct 5, 2024

Conversation

SuperKali
Copy link
Member

@SuperKali SuperKali commented Sep 30, 2024 •
edited
Loading

This PR include these changes:

  • Added functionality to display local IPv6 addresses in the MOTD.
  • Reverted: Default behavior now excludes interfaces matching 'br-*' and 'veth'.
  • This PR is referenced to another PR Add ipv6 addresses if present and sort ips #7299, will be closed.

How Has This Been Tested?

Tested on my board:

For privacy reason I didn't include the WAN IP on the screenshot 👀

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@SuperKali
Improvement: Update MOTD to include IPv6 addresses (local) and exclud…
3adbd83 
…e specified interfaces by default

- Added functionality to display local IPv6 addresses in the MOTD.
- Default behavior now excludes interfaces matching 'br-*' and 'veth'.
@SuperKali SuperKali requested a review from a team as a code owner September 30, 2024 21:36
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines BSP Board Support Packages labels Sep 30, 2024
@SuperKali SuperKali added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 30, 2024
@igorpecovnik
Copy link
Member

Default behavior now excludes interfaces matching 'br-*' and 'veth'.

I don't think this is a good idea. If bridge is set, then there is IP address set.

@SuperKali
Copy link
Member Author

Default behavior now excludes interfaces matching 'br-*' and 'veth'.

I don't think this is a good idea. If bridge is set, then there is IP address set.

Ok, i will remove it from the commit

igorpecovnik
igorpecovnik requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs instead of spaces
https://github.com/armbian/build/blob/main/.editorconfig#L9

@SuperKali
Copy link
Member Author

tabs

I will check tomorrow :)

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Oct 4, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines and removed size/medium PR with more then 50 and less then 250 lines labels Oct 4, 2024
@SuperKali SuperKali removed the Work in progress Unfinished / work in progress label Oct 4, 2024
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Oct 4, 2024
@SuperKali SuperKali removed the Needs review Seeking for review label Oct 4, 2024
@igorpecovnik igorpecovnik merged commit be47af9 into armbian:main Oct 5, 2024
3 checks passed
@SuperKali SuperKali deleted the update-motd branch October 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvollmar nvollmar nvollmar left review comments

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperKali @igorpecovnik @nvollmar