Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debsums: changing default checking as it will fail on base-files #7301

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 26, 2024

Description

Base files are changed during the process. We already planned to set this off by default but conditions || and && got mixed. Debsums authors recommends to use other tools anyway:

If you are looking for an integrity checker that can run from safe media, do integrity checks on checksum databases and can be easily configured to run periodically to warn the admin of changes see other tools such as: aide, integrit, samhain, or tripwire.

FORCE_CHECK_MD5_PACKAGES=yes turns checking back on.

Closing #7048

How Has This Been Tested?

  • Error with enable, no error with this fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Base files are changed during the process.

FORCE_CHECK_MD5_PACKAGES=yes turns checking back on.
@igorpecovnik igorpecovnik requested a review from a team as a code owner September 26, 2024 12:07
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Sep 26, 2024
@igorpecovnik igorpecovnik changed the title MD5 sum: changing default checking as it will fail on base-files debsums: changing default checking as it will fail on base-files Sep 26, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 26, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 29, 2024
@igorpecovnik igorpecovnik merged commit 6a03d07 into main Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants