Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: rockchip: fix gmac PHY attach error on ROCK Pi E #7202

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

RadxaNaoki
Copy link
Contributor

@RadxaNaoki RadxaNaoki commented Sep 10, 2024

Description

ROCK Pi E 1000M port is not working due to following error:

rk_gmac-dwmac ff540000.ethernet end0: __stmmac_open: Cannot attach to PHY (error: -19)

Documentation summary for feature / change

this patch fixes above error and make 1000M port usable.

How Has This Been Tested?

  • connect 1000M port and see dmesg
  • connect 1000M port and see ip a

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 10, 2024
@SteeManMI
Copy link
Contributor

I think you may need to also make this fix in the 6.10 edge kernel tree. Otherwise when current moves to 6.1? you will loose this fix.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 10, 2024
this fixes following error:

rk_gmac-dwmac ff540000.ethernet end0: __stmmac_open: Cannot attach to PHY (error: -19)

Signed-off-by: FUKAUMI Naoki <[email protected]>
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Sep 10, 2024
@RadxaNaoki
Copy link
Contributor Author

I think you may need to also make this fix in the 6.10 edge kernel tree. Otherwise when current moves to 6.1? you will loose this fix.

done. thanks!

@igorpecovnik
Copy link
Member

Should we re-make images from download section?

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Sep 11, 2024
@igorpecovnik igorpecovnik merged commit b1cbd00 into armbian:main Sep 11, 2024
3 checks passed
@RadxaNaoki
Copy link
Contributor Author

Should we re-make images from download section?

24.8.1? then, please remake images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

3 participants