Enable ksmbd consistently across configurations #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpapadakos
requested review from
chainsx,
AGM1968,
PanderMusubi,
Tonymac32,
krachlatte,
pyavitz,
schwar3kat,
teknoid,
sgjava,
Manouchehri,
TRSx80,
ahoneybun,
amazingfate,
brentr,
catalinii,
clee,
joekhoobyar,
paolosabatino,
rpardini,
efectn,
igorpecovnik,
lanefu,
monkaBlyat,
sputnik2019,
ManoftheSea,
Heisath,
SteeManMI,
adeepn and
echatzip
as code owners
github-actions
bot
added
size/medium
adeepn
approved these changes
Sep 3, 2024
|
Perhabs run a build train on this one? Just in case something won't build. @armbian/release-manager |
|
@EvilOlaf Is that something CI related or do you mean I should build all the kernels? |
This message wasn't for you. I adjusted. |
igorpecovnik
approved these changes
Sep 3, 2024
igorpecovnik
added
Ready to merge
|
CI needs fixing. Will merge and see if it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ksmbd consistently across configurations
Description
KSMBD is an in kernel SMB server which is good for performance specially for these SOCs.
It's also considered stable by the kernel team itself and the userspace tools are available by default in the debian-repos as the package ksmbd-tools.
I noticed that the module has only been enable for some boards or say in edge but not current version of a board family configuration.
How Has This Been Tested?
All configs already mentioned CONFIG_SMB_SERVER. Some just did not enable it and of course for many or most cases it was actually already enabled.
I have tested on my odroid hc2 (odroidxu4 family) and on my other two boards renegade and nanopi neo3 (both rk3328) ksmbd is already present end enabled
Checklist:
Please delete options that are not relevant.