Scope lock acquisition more tightly

armanbilge · Sep 21, 2023 · 2b1f537 · 2b1f537
1 parent bc3bb0c
commit 2b1f537
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/std/shared/src/main/scala/cats/effect/std/Hotswap.scala b/std/shared/src/main/scala/cats/effect/std/Hotswap.scala
@@ -117,13 +117,12 @@ object Hotswap {
       def initialize: F[Ref[F, State]] =
         F.ref(Cleared)
 
-      def finalize(state: Ref[F, State]): F[Unit] = exclusive.surround {
+      def finalize(state: Ref[F, State]): F[Unit] =
         state.getAndSet(Finalized).flatMap {
-          case Acquired(_, finalizer) => finalizer
+          case Acquired(_, finalizer) => exclusive.surround(finalizer)
           case Cleared => F.unit
           case Finalized => raise("Hotswap already finalized")
         }
-      }
 
       def raise(message: String): F[Unit] =
         F.raiseError[Unit](new RuntimeException(message))