Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PulsarConfig into common/config (Making the build more stable #217) (Move PulsarConfig into common/config (#217) #3907)
ARMADA-2848 Move PulsarConfig into commonconfig
Update test name TestValidateHasJobSetID->Id
Revert unintended changes to yarn.lock file
fix import order
(cherry picked from commit 35cb59f)
Adding ControlPlaneEventsTopic to pulsar config
Evolving ControlPlaneEvents message structure
We've decided on a parent/wrapper message for the ControlPlaneEvents to avoid passing around ambiguous proto.Message slices in the Publisher and Ingester.
Setting maxAllowedMessageSize to correct value in relevant tests
Removing reason for uncordon requests to the executor service
Moving event creation time to parent Control Plane Event, modifying executor service rpcs to reflect the events being published, changed pulsar message keys to hard coded strings rather than proto name
Renaming UpdateExecutorSettings rpc to UpsertExecutorSettings
Removing message keys from ControlPlaneEvent messages, reverting method name changes
Renaming LimitEventSequencesByteSize
Adding executor cordoning functionality to armadactl
Renaming ControlPlaneEvent to Event
Simplifying executor cordoning code
More sane checks on UpsertExecutorSettings rpc, better error messages
Typo
Updated command descriptions for executor cordoning and uncordoning
Separating executor service args from controlplaneevents
Executor Service Initial rough project skeleton #2 (Add Kerberos support #254)
Generalising common ingestion pipeline
Removing unused config
Amending comments and variable names in common ingestion pipeline to be more event agnostic
Returning to original metric name, denoting ingested event type via labal rather than metric name
Import ordering
Generalising pulsar publisher
Executor Service Adding circleci config file #3 (Add support for namespaces in load tester. #255)
Modifying SchedulerIngester to ingest control plane events, creating executor settings table and associated plumbing
Simplifying dbops merge for controlplanevents
Moving DBOperation scoping into schedulerdb
Adding GetOperation method to DBOperation, determining locking using this
Executor Service Setting Go modules to ON in circleci #4 (Fix renewing of cancelled jobs. #257)
Implementing cluster cordoning in scheduler
Filter executors from previous filter result
Adding default value for queue label when publishing controlplaneevent metrics
Fixes #
Special notes for your reviewer:
Summary of changes: