Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only evict jobs if we know about their queue #4001

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Oct 11, 2024

It's possible that there may be jobs running on a node for which we don't have queue information. Examples of this are:

  • Jobs that we started running when the queue existed, but the queue has now been deleted.
  • Jobs that were running on a given pool and that pool has now been deleted.

Evicting these jobs is problematic as we have no queue information to decide how to treat them. This change modifies the evictors so that we consider them unevictable.

Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
@d80tb7 d80tb7 changed the title [WIP] Only evict jobs if we know about their queue Only evict jobs if we know about their queue Oct 11, 2024
@d80tb7 d80tb7 enabled auto-merge (squash) October 11, 2024 15:29
@d80tb7 d80tb7 merged commit 3cd72a2 into master Oct 11, 2024
24 checks passed
@d80tb7 d80tb7 deleted the f/chrisma/no-queue branch October 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants