Automatically expire Pulsar scheduler Redis map entries #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Redis map entry deletion. Separating submit_from_log.go logic depending on scheduler * Revert "Redis map entry deletion. Separating submit_from_log.go logic depending on scheduler" This reverts commit 9d12da33d2b61a158d2b45793bc20a1490b1fbc1. * Simpler implementation of redis entry deletion * Calling correct method on event to avoid panics * Checked if event is terminal before expiring entry, checked for preempted events * Made returned error more explicit
… albin/redis-map-deletion
MustafaI
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.