Skip to content

Commit

Permalink
Fixing helm chart format (#262)
Browse files Browse the repository at this point in the history
Currently the helm charts generated are misaligned
 - i.e Sections like ports was falling under resources and therefore was invalid
This allows them to be applied successfully
  • Loading branch information
JamesMurkin authored Nov 28, 2019
1 parent eb3a23a commit 0703d32
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion deployment/armada/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
{{- toYaml .Values.env | nindent 12 -}}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 -}}
{{- toYaml .Values.resources | nindent 12 }}
ports:
- containerPort: {{ .Values.applicationConfig.grpcPort }}
protocol: TCP
Expand Down
6 changes: 3 additions & 3 deletions deployment/executor/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{ toYaml .Values.env | indent 12 }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 -}}
{{- toYaml .Values.resources | nindent 12 }}
ports:
- containerPort: 9001
protocol: TCP
Expand All @@ -49,9 +49,9 @@ spec:
securityContext:
allowPrivilegeEscalation: false
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 -}}
{{- toYaml .Values.nodeSelector | nindent 8 }}
tolerations:
{{- toYaml .Values.tolerations | nindent 8 -}}
{{- toYaml .Values.tolerations | nindent 8 }}
volumes:
- name: user-config
secret:
Expand Down
2 changes: 1 addition & 1 deletion deployment/executor/templates/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ type: Opaque
data:
{{ include "executor.config.filename" . }}: |
{{- if .Values.applicationConfig }}
{{- toYaml .Values.applicationConfig | b64enc | indent 4 }}
{{ toYaml .Values.applicationConfig | b64enc | indent 4 }}
{{- end }}

0 comments on commit 0703d32

Please sign in to comment.