Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete cronjobs when pruning disabled and actually reconcile scheduler corncobs #338

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Nov 19, 2024

Fixes #337

  • Reconcile scheduler pruner cron jobs
  • Update logic to delete previously enabled cron jobs when pruning is disabled. Otherwise, disabling pruning does nothing and the jobs will continue to run.

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

See unit tests.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@Sovietaced Sovietaced marked this pull request as ready for review November 19, 2024 06:02
Signed-off-by: Jason Parraga <[email protected]>
@Sovietaced Sovietaced requested a review from dejanzele November 21, 2024 02:07
@dejanzele dejanzele merged commit 9e41715 into armadaproject:main Nov 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling DB pruning does not delete CronJobs
2 participants