Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename serde for Self_ to "self" for direct deserialization of JSON #502

Closed
wants to merge 1 commit into from

Conversation

lthiery
Copy link

@lthiery lthiery commented Feb 12, 2024

Summary

This renames the serde of the Self_ field to be self. This allows the structs to be directly deserialized from JSON.

Checklist

@augustoccesar
Copy link
Contributor

Changes to files under the generated folder would be overwritten next time that the schema is updated.
There is a PR already to do this change on the codegen that will solve this issue (#490).

@arlyon
Copy link
Owner

arlyon commented Feb 15, 2024

Closing in favour of #490 which is merged now.

@arlyon arlyon closed this Feb 15, 2024
@lthiery
Copy link
Author

lthiery commented Feb 15, 2024

Oh great, thanks! And thanks for pointing out the other PR - good to understand a little better how the codegen works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants