gen2 profiles (design proposal 3) #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpool/manifest.yaml
|
Fixes #98 |
Rohitrajak1807
approved these changes
Dec 6, 2022
cruizen
approved these changes
Dec 6, 2022
Co-authored-by: Rohit Rajak <[email protected]>
remove null import of 'embed' Co-authored-by: Rohit Rajak <[email protected]>
remove null import of 'embed' Co-authored-by: Rohit Rajak <[email protected]>
Closed
cruizen
pushed a commit
that referenced
this pull request
Dec 16, 2022
Design doc: https://github.com/arlonproj/arlon/blob/private/leb/multiprofiles/docs/gen2_profiles_proposal_3.md Testing: - unit test located at pkg/appprofile/appprofile_test.go - E2E test: make e2e-appprofiles ------ squashed commits ------ * gen2 profiles * update gen2 profiles doc * use applicationset apis from argo-cd repo * initial AppProfile API, needs 'make' to regenerate code * after make generate * initial implementation of AppProfiles - untested * fix circular import loop * appprofiles reconciliation started working * appprofiles reconciliation - improvements * add application (cluster) and applicationset (app) reconciliation * doc for gen2 profles - proposal 2 * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * add arlon-gen2-profiles-reconc-algo.png * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * Update gen2_profiles_proposal_2.md * fix reconciliation bug: don't take address of temp loop variable * Update gen2_profiles_proposal_2.md * multiple profiles support: initial implementation * fixes ... seems to work now * use a better time encoder for zap logger * more logging tweaks to make log lines shorter * unit test, first iteration * unit test enhancements * more unit test enhancements * even more unit test enhancements * add 'appprofile list' command * display app-profiles in 'app list' command output * 'appprofile list' and 'app create' commands, display app-profiles in 'app list' command output * fix unit test * new 'app delete' command * display appprofiles in 'cluster list' command * fix nil pointer deref bug in reconciliation * new 'cluster setappprofiles' command * new document for proposal 3 of gen2 profiles * Update gen2_profiles_proposal_3.md * Update gen2_profiles_proposal_3.md * set CONTROLLER_TOOLS_VERSION to v0.10.0 * remove ngprofile and app/[add_to|remove_from]_profile commands * Makefile: add unittests target * add unit tests to github CI workflow * set arlon image version to 0.10.0 in deployment yaml * RBAC settings for appprofile * add examples/declarative and examples/clustertemplates * remove sshKeyName field from example cluster manifest * rename my-cluster -> mycluster * prepare base cluster files for examples/clustertemplates/eks-managed-mpool/manifest.yaml * rename my-cluster -> mycluster in cluster.yaml * consolidate example apps into single file * raise arlon controller memory request and limit * again raise arlon controller (the other one) memory request and limit * fix repoUrl for redis example app * (WIP) add e2e test for appprofiles * fix relative path to example manifests * fix relative path to example manifests again * e2e-appprofiles: fix the expected values for MachinePool * e2e-appprofiles: fix the API version for MachinePool * Update .github/workflows/ci.yml Co-authored-by: Rohit Rajak <[email protected]> * Update cmd/app/create.go remove null import of 'embed' Co-authored-by: Rohit Rajak <[email protected]> * Update cmd/app/delete.go remove null import of 'embed' Co-authored-by: Rohit Rajak <[email protected]> * remove unittests target because pkgtest does same thing * remove unused constant Co-authored-by: Bich Le <[email protected]> Co-authored-by: arlon automation <[email protected]> Co-authored-by: Rohit Rajak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://github.com/arlonproj/arlon/blob/private/leb/multiprofiles/docs/gen2_profiles_proposal_3.md
Testing: