Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to enable code coverage reporting #327

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Update CI to enable code coverage reporting #327

merged 7 commits into from
Nov 29, 2022

Conversation

cruizen
Copy link
Member

@cruizen cruizen commented Nov 22, 2022 •
edited
Loading

Using CodeCov support for GitHub Actions
Fixes #328

Following the example at https://github.com/codecov/example-go/blob/main/.github/workflows/ci.yml

Note that we are not making this a blocking check. Making it informational only for now (set in $REPO_ROOT/codecov.yml)
Reference: https://docs.codecov.com/docs#tips-and-tricks

@cruizen cruizen self-assigned this Nov 22, 2022
@cruizen cruizen added the enhancement New feature or request label Nov 22, 2022
@cruizen cruizen changed the title Update ci.yml Update ci.yml to enable code coverage reporting Nov 22, 2022
@cruizen cruizen changed the title Update ci.yml to enable code coverage reporting Update CI to enable code coverage reporting Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@e4e6635). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e335153 differs from pull request most recent head ac85a6f. Consider uploading reports for the commit ac85a6f to get more accurate results

@@          Coverage Diff          @@
##             main   #327   +/-   ##
=====================================
  Coverage        ?      0           
=====================================
  Files           ?      0           
  Lines           ?      0           
  Branches        ?      0           
=====================================
  Hits            ?      0           
  Misses          ?      0           
  Partials        ?      0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cruizen cruizen temporarily deployed to arlon November 22, 2022 23:06 Inactive
@cruizen cruizen temporarily deployed to arlon November 27, 2022 03:25 Inactive
@cruizen cruizen temporarily deployed to arlon November 27, 2022 03:27 Inactive
Rohitrajak1807 and others added 4 commits November 29, 2022 15:10
@Rohitrajak1807 @cruizen
Update and expand contributor guide (#330)
2f0349d 
* add key points

* add doc change instructions
add workspace slack link
(e2e doc link broken)

* e2e doc link not broken
update pymdown-extensions to 9.9 from 9.8, e2e_testing.md moved to docs dir
@ShaunakJoshi1407 @cruizen
Modify basecluster configuration for capa v2.0 (#326)
49bdb57 
* Modify awsmanagedmachinepool and awsmachinetemplate for capa v2.0

* Change apiVersion for e2e tests

* Changing apiVersion for AWSMachinePool

* Increaed timeout for assertion in e2e tests

* Adding back vibeta1 manifests in configurations.yaml for compatibility with older CAPA versions

* Removing debugging from e2e setup script
@dependabot @cruizen @Rohitrajak1807
Bump ArgoCD lib to v2.4.17 (from v2.4.16), k8s libs to v0.23.14 (from…
d72bb4f 
… v0.23.13), sigs.k8s.io/cluster-api-provider-aws from 1.5.1 to 1.5.2 (#322)

* Bump sigs.k8s.io/cluster-api-provider-aws from 1.5.1 to 1.5.2

Bumps [sigs.k8s.io/cluster-api-provider-aws](https://github.com/kubernetes-sigs/cluster-api-provider-aws) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases)
- [Commits](kubernetes-sigs/cluster-api-provider-aws@v1.5.1...v1.5.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/cluster-api-provider-aws
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update e2e_setup.sh

* Update kuttl to v0.14.0 from v0.13.0
* Update kind from v0.14 to v0.17
* Restrict ArgoCD CLI version to 2.4.17 instead of downloading the latest
* Bump ArgoCD lib from v2.4.16 to patch v2.4.17, bump k8s libs from v0.23.13 to patch v0.23.14
* fix broken argocd cli dl link
* fix broken mv for kuttl

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Rohitrajak1807 <[email protected]>
@ShaunakJoshi1407 @cruizen
Documentation changes in installation and tutorial (#315)
db9f6be 
* Doc changes

* Added basecluster manifest for AWSManagedMachinePool in docs

* Added prerequisite checks for basecluster manifest creation

* Reformatting the gen2 tutorial

* Adding headings in gen2 tutorial

* Minor change in heading

* Add note about CAPA version

* Change order of validategit and preparegit comands

* Adding baseclusters in design.md

* Adding requested changes

* Many small fixes in docs suggested by yamllint

* Many small fixes in docs suggested by yamllint


Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Trilok Khairnar <[email protected]>
@cruizen cruizen temporarily deployed to arlon November 29, 2022 09:42 Inactive
ShaunakJoshi1407
ShaunakJoshi1407 reviewed Nov 29, 2022
View reviewed changes
pkg/basecluster/data.go
@@ -77,6 +77,14 @@ nameReference:
kind: MachineDeployment
- path: spec/machineTemplate/infrastructureRef/name
kind: KubeadmControlPlane
- kind: AWSMachineTemplate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this got added as a part of the CAPA v2.0 change rebase

@cruizen cruizen merged commit 493aeb8 into main Nov 29, 2022
@cruizen cruizen deleted the private/main/trilok/add_code_coverage branch November 29, 2022 11:34
cruizen added a commit that referenced this pull request Dec 16, 2022
@cruizen @Rohitrajak1807
@ShaunakJoshi1407 @dependabot
Update CI to enable code coverage reporting (#327)
94c86f1 
* Update ci.yml

* Create codecov.yml

* Update and expand contributor guide (#330)

* add key points

* add doc change instructions
add workspace slack link
(e2e doc link broken)

* e2e doc link not broken
update pymdown-extensions to 9.9 from 9.8, e2e_testing.md moved to docs dir

* Modify basecluster configuration for capa v2.0 (#326)

* Modify awsmanagedmachinepool and awsmachinetemplate for capa v2.0

* Change apiVersion for e2e tests

* Changing apiVersion for AWSMachinePool

* Increaed timeout for assertion in e2e tests

* Adding back vibeta1 manifests in configurations.yaml for compatibility with older CAPA versions

* Removing debugging from e2e setup script

* Bump ArgoCD lib to v2.4.17 (from v2.4.16), k8s libs to v0.23.14 (from v0.23.13), sigs.k8s.io/cluster-api-provider-aws from 1.5.1 to 1.5.2 (#322)

* Bump sigs.k8s.io/cluster-api-provider-aws from 1.5.1 to 1.5.2

Bumps [sigs.k8s.io/cluster-api-provider-aws](https://github.com/kubernetes-sigs/cluster-api-provider-aws) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases)
- [Commits](kubernetes-sigs/cluster-api-provider-aws@v1.5.1...v1.5.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/cluster-api-provider-aws
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update e2e_setup.sh

* Update kuttl to v0.14.0 from v0.13.0
* Update kind from v0.14 to v0.17
* Restrict ArgoCD CLI version to 2.4.17 instead of downloading the latest
* Bump ArgoCD lib from v2.4.16 to patch v2.4.17, bump k8s libs from v0.23.13 to patch v0.23.14
* fix broken argocd cli dl link
* fix broken mv for kuttl

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Rohitrajak1807 <[email protected]>

* Documentation changes in installation and tutorial (#315)

* Doc changes

* Added basecluster manifest for AWSManagedMachinePool in docs

* Added prerequisite checks for basecluster manifest creation

* Reformatting the gen2 tutorial

* Adding headings in gen2 tutorial

* Minor change in heading

* Add note about CAPA version

* Fix order of validategit and preparegit comands

* Adding baseclusters in design.md

* Many small fixes in docs suggested by markdownlint


Co-authored-by: Trilok Khairnar <[email protected]>
Co-authored-by: Trilok Khairnar <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Rohit Rajak <[email protected]>
Co-authored-by: Shaunak Joshi <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rohitrajak1807 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunakJoshi1407 ShaunakJoshi1407 ShaunakJoshi1407 left review comments

@Rohitrajak1807 Rohitrajak1807 Rohitrajak1807 approved these changes

@bcle bcle Awaiting requested review from bcle

@jayanth-tjvrr jayanth-tjvrr Awaiting requested review from jayanth-tjvrr

@pshanbhag pshanbhag Awaiting requested review from pshanbhag

Assignees

@cruizen cruizen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Idea] Process Improvement : Enable code coverage reporting
3 participants
@cruizen @Rohitrajak1807 @ShaunakJoshi1407