Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed flag kubeconfigPath from verify command #253

Merged

Conversation

ShaunakJoshi1407
Copy link
Member

This commit fixes: #252

cmd/verify/verify.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bcle bcle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't mean to get rid of kubeconfigPath completely, I was making the point that KUBECONFIG is a common way, but not the only way, to configure the location of the file.

@ShaunakJoshi1407 ShaunakJoshi1407 merged commit 53a2224 into main Oct 2, 2022
ShaunakJoshi1407 added a commit that referenced this pull request Oct 18, 2022
* Removed flag kubeconfigPath from verify command

* Changed error message
ShaunakJoshi1407 added a commit that referenced this pull request Oct 18, 2022
* Removed flag kubeconfigPath from verify command

* Changed error message
ShaunakJoshi1407 added a commit that referenced this pull request Oct 18, 2022
* Removed flag kubeconfigPath from verify command

* Changed error message
cruizen pushed a commit that referenced this pull request Dec 16, 2022
* Removed flag kubeconfigPath from verify command

* Changed error message
@Rohitrajak1807 Rohitrajak1807 deleted the private/main/shaunak/removeKubeConfigPathFromVerify branch February 22, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea] verify command should work without kubeconfigPath as a required parameter
3 participants