Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseclusters don't support MachinePool, AWSMachinePool, AWSManagedMachinePool #248

Closed
bcle opened this issue Sep 27, 2022 · 0 comments · Fixed by #262
Closed

baseclusters don't support MachinePool, AWSMachinePool, AWSManagedMachinePool #248

bcle opened this issue Sep 27, 2022 · 0 comments · Fixed by #262
Assignees
@bcle
Labels
bug Something isn't working size:S sprint5
Milestone
0.10.0

Comments

@bcle
Copy link
Collaborator

bcle commented Sep 27, 2022 •
edited
Loading

CAPI EKS clusters can optionally use a MachinePool, whose infra field references either AWSMachinePool or AWSManagedMachinePool, which maps to EKS' unmanaged and managed node group constructs. The configurations.yaml used during prep does not include the necessary rename fields.

Aha! Link: https://pf9.aha.io/features/ARLON-307
@bcle bcle added bug Something isn't working Needs Review For all new issues that are unplanned, have no milestone or project. size:xs labels Sep 27, 2022
@bcle bcle added this to the 0.10.0 milestone Sep 27, 2022
@bcle bcle added this to 0.10.0 Sep 27, 2022
@bcle bcle self-assigned this Sep 27, 2022
@bcle bcle moved this to In Progress in 0.10.0 Sep 27, 2022
@bcle bcle changed the title baseclusters probably don't support AWSManagedMachinePool baseclusters don't support MachinePool, AWSMachinePool, AWSManagedMachinePool Sep 27, 2022
@cruizen cruizen added the sprint5 label Oct 6, 2022
bcle pushed a commit that referenced this issue Oct 11, 2022
fix #248
3222b01
@bcle bcle mentioned this issue Oct 11, 2022
Merged
@cruizen cruizen added the in_code_review PRs which are in the process of code review label Oct 14, 2022
@bcle bcle closed this as completed in #262 Oct 18, 2022
bcle added a commit that referenced this issue Oct 18, 2022
@bcle
fix #248 - support for several AWS MachinePool types (#262)
07987d0 
* fix #248

* add support for AWSMachinePool

Co-authored-by: Bich Le <[email protected]>
Repository owner moved this from In Progress to Done in 0.10.0 Oct 18, 2022
@ShaunakJoshi1407 ShaunakJoshi1407 removed the in_code_review PRs which are in the process of code review label Nov 1, 2022
cruizen pushed a commit that referenced this issue Dec 16, 2022
@bcle @cruizen
fix #248 - support for several AWS MachinePool types (#262)
1100e11 
* fix #248

* add support for AWSMachinePool

Co-authored-by: Bich Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcle bcle

Labels
bug Something isn't working size:S sprint5
Projects
0.10.0
Status: Done
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

fix #248 - support for several AWS MachinePool types arlonproj/arlon
3 participants
@cruizen @bcle @ShaunakJoshi1407