Skip to content

Commit

Permalink
init command bugs k8s version needs a v prefix, -y flag still warns a…
Browse files Browse the repository at this point in the history
…bout AWS_SESSION_TOKEN, etcd health needs odd control plane nodes (#373)
  • Loading branch information
Rohitrajak1807 authored Dec 16, 2022
1 parent 22cabe7 commit 348b59e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions cmd/initialize/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ const (
argoServer = "127.0.0.1:8080"
exampleDir = "examples"
baseclusterDir = "baseclusters"
defaultCtrlPlaneCount int64 = 2
defaultCtrlPlaneCount int64 = 3
defaultWorkerCount int64 = 3
defaultK8sVersion = "1.23.14"
defaultK8sVersion = "v1.23.14"
)

type porfForwardCfg struct {
Expand Down
10 changes: 6 additions & 4 deletions pkg/install/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,12 @@ func (a *awsInstaller) EnsureRequisites() error {
Message: fmt.Sprintf("%s environment variable not set", env.name),
}
}
if !a.recoverOnFail(env.msg) {
return &ErrBootstrap{
HardFail: true,
Message: fmt.Sprintf("%s environment variable not set", env.name),
if !a.silence {
if !a.recoverOnFail(env.msg) {
return &ErrBootstrap{
HardFail: true,
Message: fmt.Sprintf("%s environment variable not set", env.name),
}
}
}
}
Expand Down

0 comments on commit 348b59e

Please sign in to comment.