Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix. Changed += to = in FieldVar double_in_place #142

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mskrzypkows
Copy link

@mskrzypkows mskrzypkows commented Mar 19, 2024

Description

Fixed bug in Field_var::double_in_place

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mskrzypkows mskrzypkows requested a review from a team as a code owner March 19, 2024 10:51
@mskrzypkows mskrzypkows requested review from z-tech, Pratyush and mmagician and removed request for a team March 19, 2024 10:51
@mmagician
Copy link
Member

Wasn't there a unit test for this before? Could you add one for future proofing?

@mskrzypkows
Copy link
Author

I don't see any tests for FieldVar. I'll add some.

@mskrzypkows
Copy link
Author

@mmagician What do you think, can we merge it?

@mmagician
Copy link
Member

It's currently failing due to recently introduced breaking changes in nightly. Unfortunately there's no automatic fix for these (yet, see WIP), so removing the redundant imports needs to be done manually for now.

@mskrzypkows
Copy link
Author

mskrzypkows commented Apr 18, 2024

@mmagician, @Pratyush removed unused imports, should pass now.

@mskrzypkows
Copy link
Author

🤔 Something changed in algebra with ark_std::sync?

@mskrzypkows
Copy link
Author

Can we rerun failing no_std check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants