Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #124

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Add CODEOWNERS #124

merged 4 commits into from
Sep 29, 2023

Conversation

mmagician
Copy link
Member

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen
Copy link
Member

There is an error that prevents the PR from being merged: lint private_in_public has been removed: replaced with another group of lints, see RFC https://rust-lang.github.io/rfcs/2145-type-privacy.html for more information

I replaced it with the guidelines given in the RFC, will see how it works...

@weikengchen
Copy link
Member

Ok, it seems alternatives are not stable yet, so the best bet is to remove this lint for now.

@mmagician mmagician added this pull request to the merge queue Sep 29, 2023
Merged via the queue into arkworks-rs:master with commit 9d9df60 Sep 29, 2023
4 checks passed
@mmagician mmagician deleted the add-codeowner branch September 29, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants