Fix/refactors #104
Merged
Fix/refactors #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `<E::G{1,2}Projective as VariableBaseMSM>::msm_bigint` instead of `VariableBase::msm`
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
src/ipa_pc/mod.rs
Outdated
| @@ -561,10 +586,9 @@ where | |||
| if has_hiding { | |||
| let mut rng = rng.expect("hiding commitments require randomness"); | |||
| let hiding_time = start_timer!(|| "Applying hiding."); | |||
| let mut hiding_polynomial = P::rand(d, &mut rng); | |||
| let mut hiding_polynomial = P::rand(0, &mut rng); | |||
There was a problem hiding this comment.
Seems that this one changes the logic here?
weikengchen
reviewed
Aug 26, 2022
weikengchen
reviewed
Aug 26, 2022
|
Still, see the issue above. |
weikengchen
requested changes
Aug 26, 2022
weikengchen
approved these changes
Aug 26, 2022
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for changes in algebra - replace uses of tobytes with canonicalserialize, and added mul import where necessary.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.