Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absorb derive #135

Merged
merged 15 commits into from
Feb 9, 2024
Merged

Absorb derive #135

merged 15 commits into from
Feb 9, 2024

Conversation

mmagician
Copy link
Member

@mmagician mmagician commented Jan 25, 2024 •
edited
Loading

Description

closes: #133

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmagician mmagician marked this pull request as ready for review January 25, 2024 20:45
@mmagician mmagician requested a review from a team as a code owner January 25, 2024 20:45
@mmagician mmagician requested review from z-tech, Pratyush and weikengchen and removed request for a team January 25, 2024 20:45
@mmagician mmagician changed the title Absorb derive Absorb derive Jan 25, 2024
@mmagician mmagician mentioned this pull request Feb 6, 2024
Open
6 tasks
Pratyush
Pratyush reviewed Feb 9, 2024
View reviewed changes
macros/LICENSE-APACHE Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed Feb 9, 2024
View reviewed changes
macros/LICENSE-MIT Outdated Show resolved Hide resolved
Pratyush
Pratyush approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo a couple of nits!

@mmagician mmagician added this pull request to the merge queue Feb 9, 2024
Merged via the queue into arkworks-rs:main with commit ccf9d95 Feb 9, 2024
5 checks passed
@mmagician mmagician deleted the absorb-derive branch February 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add #[proc_macro_derive(Absorb)] on custom structs
2 participants
@mmagician @Pratyush