Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the visibility for G2 ell coeffs and related algorithms #817

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Apr 5, 2024

Description

This PR proposes to make it possible for a caller to use Arkworks-rs to obtain the ell coeffs and use it in other places.

Without this change, in the BitVM example here (https://github.com/BitVM/BitVM/blob/main/src/bn254/ell_coeffs.rs), one who wants to use Arkworks-rs's algorithm to get the ell coeffs would need to copy-paste the code.

This PR suggests that, since these ell coeffs are useful to the outside, it may be worthwhile to reveal them.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

N/A:

  • Wrote unit tests
  • Updated relevant documentation in the code

@weikengchen weikengchen requested review from a team as code owners April 5, 2024 23:13
@weikengchen weikengchen requested review from z-tech, Pratyush and mmagician and removed request for a team April 5, 2024 23:13
@weikengchen weikengchen added this pull request to the merge queue Apr 5, 2024
Merged via the queue into master with commit 1bc20ce Apr 6, 2024
40 checks passed
@weikengchen weikengchen deleted the pub_g2_coeffs_and_algs branch April 6, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants