Relax Arc cfg; remove Send bound from Valid; implement Valid & CanonicalDeserialize for Rc
#811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmagician
requested review from
z-tech,
Pratyush and
weikengchen
and removed request for
a team
|
So, I think the remaining action item is to remove the patch? |
|
@weikengchen no, quite the opposite. It relies on latest |
|
Let me revert my change. |
weikengchen
force-pushed
the
relax-arc-cfg
branch
from
8c3c0e0
to
c4c397d
Compare
|
But it looks like ready to merge? I think the changes are easy to follow and seem straightforward. |
|
Yes, it's ready to merge. The dependency PR had already been merged to |
weikengchen
approved these changes
Apr 5, 2024
weikengchen
reviewed
Apr 5, 2024
mmagician
added a commit
to mmagician/crypto-primitives
that referenced
this pull request
Apr 7, 2024
needed after arkworks-rs/algebra#811
6 tasks
autquis
pushed a commit
to NP-Eng/crypto-primitives
that referenced
this pull request
Apr 7, 2024
needed after arkworks-rs/algebra#811 Need to add Sync trait bounds on a few types
github-merge-queue bot
pushed a commit
to arkworks-rs/crypto-primitives
that referenced
this pull request
Apr 9, 2024
* Fix build for different features with `no-std` * Fix for constraints of each feature * Fix CI * Do a `cargo fmt` * patch std needed after arkworks-rs/algebra#811 Need to add Sync trait bounds on a few types --------- Co-authored-by: mmagician <[email protected]>
6 tasks
mmagician
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #649
depends on arkworks-rs/std#48
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer