Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert #679 (#687)" #696

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Revert "Revert #679 (#687)" #696

merged 1 commit into from
Jan 11, 2024

Conversation

mmagician
Copy link
Member

This reverts commit 5dfeedf.

Description

See discussion in #659 (comment)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mmagician mmagician requested review from a team as code owners October 31, 2023 13:19
@mmagician mmagician requested review from z-tech, Pratyush and weikengchen and removed request for a team October 31, 2023 13:19
@mmagician mmagician mentioned this pull request Oct 31, 2023
Merged
6 tasks
@mmagician
Copy link
Member Author

@Pratyush let's proceed with this PR if we can, as it's also a blocker for #659

@Pratyush
Copy link
Member

Sure. Let's just hope we don't end up with a "Revert "Revert "Revert ...""" after this =P

@Pratyush Pratyush added this pull request to the merge queue Jan 11, 2024
Merged via the queue into arkworks-rs:master with commit 0c945fa Jan 11, 2024
37 checks passed
@mmagician mmagician deleted the rev-rev-new-map-to-curve branch January 11, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmagician @Pratyush