Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make AffineRepr::xy() more flexible #593

Merged
merged 7 commits into from
Apr 24, 2023

Commits on Feb 8, 2023

  1. feat: make AffineRepr::xy() more flexible

    Currently [`AffineRepr::xy()` returns the field elements as references]. This is
    only possible if the underlying data structure that implements that traits owns
    those field elements and can directly have a reference to it.
    
    Though there are cases, where providing those direct references is not possible.
    For example if the underlying structure has a different layout, or if the fields
    elements you're returning need to be wrapped in a newtype struct (that's my case).
    
    With this change, `AffineRepr::xy()` now returns owned data. It's more flexible
    as now the underlying data structure can have any shape as long as it can return
    those field elements somehow.
    
    [`AffineRepr::xy()` returns the field elements as references]: https://github.com/arkworks-rs/algebra/blob/4e4fc17e69178ab7f929602f17a5e769ebaf34c7/ec/src/lib.rs#L208
    vmx committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8b2fd03 View commit details
    Browse the repository at this point in the history
  2. chore: add changelog entry

    vmx committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ba5ed7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f74bac9 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Configuration menu
    Copy the full SHA
    5581306 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ee3b5d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    f2c951b View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. Configuration menu
    Copy the full SHA
    8b7091e View commit details
    Browse the repository at this point in the history