-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Canonical(De-)Serialize to miller loop args #571
Conversation
Need to fix the tests first, will do later! |
Why does this help? Isn't it enough the specific model knows it can serialize its own G2Prepared? |
But this is what @Pratyush suggested in #537 (comment) ? There is something wrong with the test curves / |
Changing |
After a detailed discussion we concluded that we still have to fork the models for usage in Substrate so that this PR is no longer a requirement for us. |
Description
Adds
CanonicalSerialize
andCanonicalDeserialize
traits to the arguments ofmulti_miller_loop
.This originates from a discussion in #537 and is in some sense a follow-up of the PR's #534 and #542. It allows to avoid point preparation and instead to (de-)serialize the arguments of
multi_miller_loop
right away. It should finally be possible to over-come the forked models in paritytech/substrate#13031 with this.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
- [ ] Wrote unit testsPending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer