Fix test_fft
for BLS12-381 domain 2^32 * 3
#547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some TurboPlonk implementations, a degree-five gate is being used. So, there are two domains being used.
To allow the algorithm to use a mixed-radix domain (instead of 2^k * 2 * 2 * 2), we want to add the small subgroup base for BLS12-381's Fr. However, the
test_fft
test appears to be insufficient for2^32
already, not to mention2^32 * 3
.Note that this improvement is important in practice because it saves 25% of the MSM when using Lagrange bases.
Also, the
test_fft
only tests0..ADICITY
, but it should be0..=ADICITY
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the GitHub PR explorerN/A:
Pending
section inCHANGELOG.md