Fix incorrect square for Fp128
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
requested review from
mmagician and
weikengchen
and removed request for
a team
mmagician
reviewed
Nov 30, 2022
6 tasks
mmagician
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
I can approve inasmuch as the new tests for fp128 pass.
Maybe it's worth adding a comment to the method explaining which algorithm is used for squaring? While the multiplication seems to follow this doc, I can't immediately see the connection to the squaring one.
|
We're not using the advanced squaring algorithm from the gnark folks. (I intend to implement that, but haven't found the cycles yet.) I can't find a reference for our existing squaring algorithm, but it's the one implemented in bellman originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer