Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some internals of ff #492

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Refactor some internals of ff #492

merged 8 commits into from
Oct 26, 2022

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Sep 29, 2022

Description

  • Splits the contents of ff/src/fields/mod.rs into smaller files for easier management.
  • Moves BitIterator out of ark_ff::fields and into ark_ff directly.
  • Adds impl<'a, 'b> Add/Sub/Mul/Div<&'a F> for &'b F

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush added T-feature Type: new features T-refactor Type: cleanup/refactor breaking-change This PR contains a breaking change labels Oct 26, 2022
Copy link
Member

@weikengchen weikengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See the documentation warnings (in GitHub/Files changed).

@weikengchen
Copy link
Member

I believe this is the last "major" breaking change for arkworks-rs at this moment. I think we can merge it soon once the docs above are handled.

@Pratyush Pratyush requested review from a team as code owners October 26, 2022 22:24
@Pratyush Pratyush merged commit 3835af5 into master Oct 26, 2022
@Pratyush Pratyush deleted the refactor-ff-internals branch October 26, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR contains a breaking change T-feature Type: new features T-refactor Type: cleanup/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants