-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some internals of ff
#492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikengchen
reviewed
Sep 30, 2022
weikengchen
reviewed
Sep 30, 2022
Pratyush
added
T-feature
Type: new features
T-refactor
Type: cleanup/refactor
breaking-change
This PR contains a breaking change
labels
Oct 26, 2022
weikengchen
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. See the documentation warnings (in GitHub/Files changed).
weikengchen
reviewed
Oct 26, 2022
weikengchen
reviewed
Oct 26, 2022
weikengchen
reviewed
Oct 26, 2022
I believe this is the last "major" breaking change for arkworks-rs at this moment. I think we can merge it soon once the docs above are handled. |
weikengchen
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
This PR contains a breaking change
T-feature
Type: new features
T-refactor
Type: cleanup/refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ff/src/fields/mod.rs
into smaller files for easier management.BitIterator
out ofark_ff::fields
and intoark_ff
directly.impl<'a, 'b> Add/Sub/Mul/Div<&'a F> for &'b F
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer