Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ec model files and curve struct names #438

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Jul 7, 2022

Description

short_weierstrass_jacobian -> short_weierstrass
twisted_edwards_extend -> twisted_edwards
GroupAffine -> Affine
GroupProjective -> Projective
ModelParameters -> CurveConfig
SWModelParameters -> SWCurveConfig
TEModelParameters -> TECurveConfig
MontgomeryModelParameters -> MontCurveConfig


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested a review from mmagician July 7, 2022 17:46
@Pratyush Pratyush added the T-refactor Type: cleanup/refactor label Jul 8, 2022
ec/README.md Outdated Show resolved Hide resolved
@Pratyush Pratyush changed the title Rename ec model files and Affine and Projective struct names Rename ec model files and curve struct names Jul 8, 2022
@Pratyush Pratyush merged commit 84ad186 into master Jul 8, 2022
@Pratyush Pratyush deleted the improve-ec-structure branch July 8, 2022 18:08
mmagician added a commit to mmagician/r1cs-std that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-refactor Type: cleanup/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants