Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map-to-curve #430

Merged
merged 76 commits into from
Jul 27, 2022
Merged

Map-to-curve #430

merged 76 commits into from
Jul 27, 2022

Commits on Feb 16, 2022

  1. Add IETF-compatible hasher

    @mmagician
    mmagician committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    241cb41 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'arkworks-rs:master' into ietf-hasher

    @mmagician
    mmagician authored Mar 9, 2022
    Configuration menu
    Copy the full SHA
    543d546 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Add empty test suites

    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    6b39930 View commit details
    Browse the repository at this point in the history

  2. Include the suites in testing

    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    72b67a6 View commit details
    Browse the repository at this point in the history

  3. Complete the hash-to-field suites 

    Hashing to correct field in either G1 or G2.
Tests don't pass yet
    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    5f1ece7 View commit details
    Browse the repository at this point in the history

  4. swap g1 > g2

    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    25a435d View commit details
    Browse the repository at this point in the history

  5. Rename IETFHasher back to DefaultHasher

    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    21d1f9d View commit details
    Browse the repository at this point in the history

  6. Rename DefaultHasher -> DefaultFieldHasher

    @mmagician
    mmagician committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    59daf69 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Read the test vectors as hex, not as raw bytes

    @mmagician
    mmagician committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2787667 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Simplify the structure of tests

    @mmagician
    mmagician committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a3b5c69 View commit details
    Browse the repository at this point in the history

  2. Update ec/Cargo.toml 

    Co-authored-by: drskalman <[email protected]>
    @mmagician @drskalman
    mmagician and drskalman authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4cd918f View commit details
    Browse the repository at this point in the history

  3. Replace lazy_static by an array

    @mmagician
    mmagician committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    605b96b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ietf-hasher' of github.com:w3f/arkworks-algebra into ie… 

    …tf-hasher
    @mmagician
    mmagician committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9d3b013 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ietf-hasher

    @mmagician
    mmagician authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    cb4311b View commit details
    Browse the repository at this point in the history

  6. Clean up a comment

    @mmagician
    mmagician committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    552ca74 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. disables default features in sha2 and sha3 and enabling alloc for 

    digest in hope to resolve the std dependancy
    @drskalman
    drskalman committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    babfe6b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Merge branch 'master' into ietf-hash-to-field

    @mmagician
    mmagician authored Apr 24, 2022
    Configuration menu
    Copy the full SHA
    e05fd6d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Move WB tests to the curve_maps

    @mmagician
    mmagician committed May 4, 2022
    Configuration menu
    Copy the full SHA
    205625a View commit details
    Browse the repository at this point in the history

  2. Move small field SWU tests to curve_maps

    @mmagician
    mmagician committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8f7dce8 View commit details
    Browse the repository at this point in the history

  3. Add test suites for g1_iso 

    Not working yet - points not matching
    @mmagician
    mmagician committed May 4, 2022
    Configuration menu
    Copy the full SHA
    0942860 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Read the serialised point as on the original curve 

    instead of on the isogeny

Unify SWU and WB maps

Revert "Unify SWU and WB maps"

This reverts commit e8a78fd.

Expose ec and g1_iso items
    @mmagician
    mmagician committed May 5, 2022
    Configuration menu
    Copy the full SHA
    1c1afcc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Merge branch 'master' into ietf-hash-to-field

    @mmagician
    mmagician authored May 6, 2022
    Configuration menu
    Copy the full SHA
    6e5eabe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ietf-hash-to-field

    @mmagician
    mmagician authored May 6, 2022
    Configuration menu
    Copy the full SHA
    190a5f9 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @mmagician @Pratyush
    mmagician and Pratyush authored May 6, 2022
    Configuration menu
    Copy the full SHA
    61e5d0d View commit details
    Browse the repository at this point in the history

  4. import the correct crate: sha2

    @mmagician
    mmagician committed May 6, 2022
    Configuration menu
    Copy the full SHA
    37dae2e View commit details
    Browse the repository at this point in the history

  5. Rename hasher/mapper constructors to just new

    @mmagician
    mmagician committed May 6, 2022
    Configuration menu
    Copy the full SHA
    efe7a10 View commit details
    Browse the repository at this point in the history

  6. Add a default SEC_PARAM value of 128

    @mmagician
    mmagician committed May 6, 2022
    Configuration menu
    Copy the full SHA
    833073e View commit details
    Browse the repository at this point in the history

  7. Remove empty line

    @mmagician
    mmagician committed May 6, 2022
    Configuration menu
    Copy the full SHA
    c2653d2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Move hash_to_field into ff crate

    @mmagician
    mmagician committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ac2aa67 View commit details
    Browse the repository at this point in the history

  2. Update doc comment for get_len_per_elem

    @mmagician
    mmagician committed May 9, 2022
    Configuration menu
    Copy the full SHA
    dd494c6 View commit details
    Browse the repository at this point in the history

  3. Remove gen_len_per_elem test

    @mmagician
    mmagician committed May 9, 2022
    Configuration menu
    Copy the full SHA
    e8f91d4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ietf-hash-to-field

    @mmagician
    mmagician authored May 9, 2022
    Configuration menu
    Copy the full SHA
    ed85740 View commit details
    Browse the repository at this point in the history

  5. Remove unused imports from ec

    @mmagician
    mmagician committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ef5b411 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ietf-hash-to-field' of github.com:mmagician/algebra int… 

    …o ietf-hash-to-field
    @mmagician
    mmagician committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ab22fc2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Merge branch 'ietf-hash-to-field' into map-to-curve-tests

    @mmagician
    mmagician committed May 10, 2022
    Configuration menu
    Copy the full SHA
    75585f9 View commit details
    Browse the repository at this point in the history

  2. assert the iso generator is actually on curve

    @mmagician
    mmagician committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f618bc6 View commit details
    Browse the repository at this point in the history

  3. Use a correct generator and curve params

    @mmagician
    mmagician committed May 10, 2022
    Configuration menu
    Copy the full SHA
    52cd898 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Update the isogeny map params to match the draft

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6e23a99 View commit details
    Browse the repository at this point in the history

  2. only negate y if parity(u) != parity(y)

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2281ccf View commit details
    Browse the repository at this point in the history

  3. Adapt parity method to be compatible for all m 

    - originally would return the oddness of first non-zero element
- adapted so that it returns true if AT LEAST one of the base field elements is odd
    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4fdba02 View commit details
    Browse the repository at this point in the history

  4. Simplify reading an fq_vec with a helper method

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9a4077c View commit details
    Browse the repository at this point in the history

  5. Use a COFACTOR param from the draft for G1

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9dbdc40 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6bfaf15 View commit details
    Browse the repository at this point in the history

  7. Bring fq12 and g2 from bls12-381 to test-curves

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    572f16c View commit details
    Browse the repository at this point in the history

  8. Implement the isogeny traits for g2

    @mmagician
    mmagician committed May 11, 2022
    Configuration menu
    Copy the full SHA
    00cb0cb View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Adapt the test suites to run for both g1 & g2 

    Revert "Adapt parity method to be compatible for all `m`"

This reverts commit 4fdba02.
    @mmagician
    mmagician committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a48b61e View commit details
    Browse the repository at this point in the history

  2. format

    @mmagician
    mmagician committed May 16, 2022
    Configuration menu
    Copy the full SHA
    1434435 View commit details
    Browse the repository at this point in the history

  3. Update the cofactor for g2

    @mmagician
    mmagician committed May 16, 2022
    Configuration menu
    Copy the full SHA
    fc4e25d View commit details
    Browse the repository at this point in the history

  4. Make the test suites more explicit 

    provide intermediate values q0, q1

adapt tests to output of P,q0,q1
    @mmagician
    mmagician committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9fa58bd View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed May 24, 2022
    Configuration menu
    Copy the full SHA
    cf55317 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    d56aa8b View commit details
    Browse the repository at this point in the history

  2. Rename xi -> zeta

    @mmagician
    mmagician committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2b9fd7e View commit details
    Browse the repository at this point in the history

  3. update cofactor to h_eff

    @mmagician
    mmagician committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    34ecae3 View commit details
    Browse the repository at this point in the history

  4. update cofactor: should be in BE

    @mmagician
    mmagician committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    7945d11 View commit details
    Browse the repository at this point in the history

  5. Remove redundant code

    @mmagician
    mmagician committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    bb8f611 View commit details
    Browse the repository at this point in the history

  6. negate the Y-isogeny for g2 BLS12-381 

    to match the specifications

Co-Authored-By: drskalman <[email protected]>
    @mmagician @drskalman
    mmagician and drskalman committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0ce9f81 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Remove XI, ZETA_ON_XI as they're no longer used

    @mmagician
    mmagician committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    5a94ff0 View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @mmagician
    mmagician committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    7174d78 View commit details
    Browse the repository at this point in the history

  3. Limit the output of hash to just one, final elem 

    instead of including the intermediate values q0, q1 in the output
    @mmagician
    mmagician committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    2f2e7ad View commit details
    Browse the repository at this point in the history

  4. no need to parse q0, q1 when reading json

    @mmagician
    mmagician committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    83666cb View commit details
    Browse the repository at this point in the history

  5. Double-ended iterator is not needed at bonud

    @mmagician
    mmagician committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    84a4d56 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    79547d1 View commit details
    Browse the repository at this point in the history

  2. Use clear_cofactor instead of mul_by_cofactor

    @mmagician
    mmagician committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    1b751c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician authored Jul 1, 2022
    Configuration menu
    Copy the full SHA
    d5f05d1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6510e2e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @Pratyush
    Pratyush authored Jul 9, 2022
    Configuration menu
    Copy the full SHA
    1a26b0d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    2741a55 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. g2 & g2_iso should have the same cofactor

    @mmagician
    mmagician committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    093e69e View commit details
    Browse the repository at this point in the history

  2. Add source for the WB-map parameters

    @mmagician
    mmagician committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    cffad6d View commit details
    Browse the repository at this point in the history

  3. Use the more efficient g2 cofactor clearing

    @mmagician
    mmagician committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    c8723ab View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into map-to-curve-tests

    @mmagician
    mmagician committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    618739e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Define generators as per method in zcash 

    Based on rationale here: https://github.com/zcash/librustzcash/blob/6e0364cd42a2b3d2b958a54771ef51a8db79dd29/pairing/src/bls12_381/README.md#generators
    @mmagician
    mmagician committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7fea6c9 View commit details
    Browse the repository at this point in the history

  2. Update comments

    @mmagician
    mmagician committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    9fbd150 View commit details
    Browse the repository at this point in the history

  3. Add explicit tests for G1, G2 generators

    @mmagician
    mmagician committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    007621b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Merge branch 'master' into map-to-curve-tests

    @Pratyush
    Pratyush authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    0183527 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into map-to-curve-tests

    @Pratyush
    Pratyush authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    540690a View commit details
    Browse the repository at this point in the history