Fix sqrt for QuadExtField #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use sqrt(c0/beta)
bls12-381 regression tests will go into the curves repo
6 tasks
weikengchen
approved these changes
Dec 6, 2021
mmagician
added a commit
to w3f/arkworks-algebra
that referenced
this pull request
Dec 6, 2021
Bug fixed in PR arkworks-rs#358
Pratyush
reviewed
Dec 7, 2021
| // or we need to compute sqrt(c0/P::NONRESIDUE) | ||
| return (self.c0.div(P::NONRESIDUE)) | ||
| .sqrt() | ||
| .map(|res| Self::new(P::BaseField::zero(), res)); |
There was a problem hiding this comment.
I wonder if there's a way to precompute P::NONRESIDUE.inverse() here
There was a problem hiding this comment.
One simple solution is to add NONRESIDUE_INV into the trait of the field parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the case when
c1 = 0&c0.legendre.is_qnr()closes: #344
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer