Add benchmarks to test-curves
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlopes11
force-pushed
the
vlopes11/bench-test-curves
branch
4 times, most recently
from
3a888b6
to
a9fdb46
Compare
The added benchmarks will measure Field, SquareRootField, AffineCurve and ProjectiveCurve for `test-curves` implementations that are bls12-381, mnt4-753 and bn384. It will also cover `test-curves` `BigInteger` implementations. It also fixes the benchmarks in `poly-benches` that aren't running due to duplicated benchmark IDs for a same given group. Closes #353
6 tasks
weikengchen
approved these changes
Jan 7, 2022
|
Hm I think the aim was to move the existing benchmark templates from curves to here, instead of adding new benchmarks here. Should we revert this PR in the meanwhile? |
|
Then let us revert this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The added benchmarks will measure Field, SquareRootField, AffineCurve
and ProjectiveCurve for
test-curvesimplementations that arebls12-381, mnt4-753 and bn384.
It will also cover
test-curvesBigIntegerimplementations.It also fixes the benchmarks in
poly-benchesthat aren't running dueto duplicated benchmark IDs for a same given group.
closes: #353
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer