Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary PhantomData #310

Merged
merged 3 commits into from
Sep 4, 2021
Merged

Remove Unnecessary PhantomData #310

merged 3 commits into from
Sep 4, 2021

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Sep 2, 2021

Description

This PR removes unnecessary PhantomData in some structures. See the following:

  • GroupAffine, GroupProjective (ec/src/models/short_weierstrass_jacobian.rs)
  • GroupAffine, GroupProjective, MontgomeryGroupAffine (ec/src/models/twisted_edwards_extended.rs)
  • CubicExtField (ff/src/fields/models/cubic_extension.rs)
  • QuadExtField (ff/src/fields/models/quadratic_extension.rs)

The rest of the changes are cargo clippy or cargo fmt updates.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • (N/A) Wrote unit tests
  • (N/A) Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen
Copy link
Member

weikengchen commented Sep 4, 2021

Hi, Brandon, I just fixed the linter issue of the master branch and is ready to merge many PRs in the next a few days.

One question: can you change this PR into "Allow edits by maintainers"? If it is right, it would be somewhere on the right of this page.
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I will then sync with the master branch and perform final cleanup if necessary.

@bhgomes
Copy link
Contributor Author

bhgomes commented Sep 4, 2021

On this pull request, it doesn't show "Allow edits by maintainers", probably because the pull request comes from an organization-fork rather than from me directly. I didn't know that this would happen if I used an organization. Next time, I'll use my own fork, but in the meantime, you can send me a diff, or I can re-fork it to my own account if you like. Sorry about the inconvenience!

Copy link
Member

@weikengchen weikengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice improvement of the existing code.

@weikengchen weikengchen merged commit 86d804b into arkworks-rs:master Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants