Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ark_ff::test_rng #293

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Remove ark_ff::test_rng #293

merged 2 commits into from
Jun 5, 2021

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Jun 5, 2021 •
edited
Loading

Description

Since 0.2.0, ark_ff::test_rng is deprecated. For the incoming release, it is now removed.

This is a breaking change.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen weikengchen requested a review from Pratyush June 5, 2021 00:53
@Pratyush Pratyush merged commit fee1330 into master Jun 5, 2021
@Pratyush Pratyush deleted the remove-ark-ff-rand branch June 5, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weikengchen @Pratyush