Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CycleEngine #292

Merged
merged 11 commits into from
Jun 5, 2021
Merged

Remove CycleEngine #292

merged 11 commits into from
Jun 5, 2021

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Jun 5, 2021

Description

In the last release, CycleEngine has been marked as deprecated. For the incoming release, CycleEngine will be removed.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

N/A:

  • Wrote unit tests

@weikengchen weikengchen changed the title Remove CycleEngine Remove CycleEngine Jun 5, 2021
@weikengchen
Copy link
Member Author

Updated the CHANGELOG. Also, remove a duplicated entry about #279.

@weikengchen weikengchen requested a review from Pratyush June 5, 2021 00:25
CHANGELOG.md Show resolved Hide resolved
ec/README.md Show resolved Hide resolved
@weikengchen weikengchen merged commit 8ad6d60 into master Jun 5, 2021
@weikengchen weikengchen deleted the retire-cycle-engine branch June 5, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants