Implement the Sum trait for all AffineCurve
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
reviewed
Jun 3, 2021
Comment on lines
+291
to
+292
| iter.map(|x| x.into_projective()) | ||
| .sum::<GroupProjective<P>>() |
There was a problem hiding this comment.
It would be faster to use mixed addition, no?
There was a problem hiding this comment.
Good point. Let me double-check. Yes, it is very likely that the conversions from affine to projective may be unnecessary as well.
There was a problem hiding this comment.
(though the latter is cheap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
George Gkitsas mentions that it would be convenient to have a
Sumtrait forAffineCurve, specifically SW curve'sGroupAffine.This PR adds the requirement that all
AffineCurvemust implement theSumtrait.It is useful to have this trait: a user who uses
+or+=in SW's AffineCurve indeed would pay performance overhead --- there are unnecessary conversions between ProjectiveCurve and AffineCurve during each addition. ASumtrait implementation that avoids such unnecessary conversions can significantly boost the performance.closes: #288
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorerFeels skippable: