Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements hashing as a blanket trait for instances of CanonicalSerialize #265

Merged
merged 5 commits into from
Apr 23, 2021

Commits on Apr 21, 2021

  1. Implements hashing as a blanket trait for instances of `CanonicalSeri…

    …alize`
    
    - this saves an alllocation w.r.t the suggested approach by implementing `io::Write` on the input instance of `digest::Digest`,
    - note that most instances of `digest::Digest` [already](https://gist.github.com/huitseeker/e827161413063e347ce5a496b66ff287) have an [`io::Write` instance](https://github.com/rustcrypto/hashes#hashing-readable-objects), but `CanonicalSerialize` consuming its `io::Write` argument prevents its usage,
    - this hence implements `io::Write` on a [cheap newtype wrapper](https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html)
    
    Fixes arkworks-rs#86
    huitseeker committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    ffeaf83 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Adjust post review

    - rename Hash -> CanonicalSerialize Ext according to [extension trait best practices](https://rust-lang.github.io/rfcs/0445-extension-trait-conventions.html#the-convention)
    - add the same structure for hashing uncompressed bytes
    huitseeker committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    2afbe5c View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Configuration menu
    Copy the full SHA
    476c659 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    426b91a View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG.md

    weikengchen authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    98d6833 View commit details
    Browse the repository at this point in the history