Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rand with ark_std::rand #201

Merged
merged 5 commits into from
Feb 5, 2021
Merged

Replace rand with ark_std::rand #201

merged 5 commits into from
Feb 5, 2021

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Feb 5, 2021 •
edited
Loading

Description

This PR replaces all the use of rand with ark_std::rand.

In addition, XorShiftRng is likely outdated and should be replaced by ark_std::test_rng. This PR also makes this change.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen weikengchen requested review from ValarDragon and Pratyush and removed request for ValarDragon February 5, 2021 02:29
@Pratyush
Copy link
Member

Pratyush commented Feb 5, 2021

Amazing, thanks for this!

@weikengchen weikengchen merged commit 80ff5ea into master Feb 5, 2021
@weikengchen weikengchen deleted the remove-rand branch February 5, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@ValarDragon ValarDragon Awaiting requested review from ValarDragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weikengchen @Pratyush