Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFT parallelization threshold #171

Merged
merged 2 commits into from
Jan 9, 2021
Merged

FFT parallelization threshold #171

merged 2 commits into from
Jan 9, 2021

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Jan 8, 2021

Description

Adds a threshold when parallelizing FFTs. Currently the threshold is derived empirically; it gives speedups of between 15-30% compared to the non-threshold version.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Copy link
Member

@weikengchen weikengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. But, a comment noting that this number is chosen empirically in the code would be helpful I think.

@Pratyush
Copy link
Member Author

Pratyush commented Jan 9, 2021

Ok, done!

@Pratyush Pratyush merged commit 1a5c6b5 into master Jan 9, 2021
@Pratyush Pratyush deleted the fft-parallel-threshold branch January 9, 2021 04:55
@ValarDragon
Copy link
Member

Thanks for integrating this! We should still benchmark this against hardcoding the base case tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants