Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sqrt computations when input is *not* a sqrt #142

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix sqrt computations when input is *not* a sqrt #142

merged 2 commits into from
Dec 16, 2020

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Dec 16, 2020 •
edited
Loading

Description

Fixes the issues due to #131, #137

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

ValarDragon
ValarDragon approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! (And sorry for introducing the issue 😓 )

Do we not have sqrt tests in algebra, seems like it should have been caught by that?

@ValarDragon ValarDragon merged commit 3afc81d into master Dec 16, 2020
@ValarDragon ValarDragon deleted the fix-sqrt branch December 16, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pratyush @ValarDragon