-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ark std rand #129
Ark std rand #129
Conversation
That second commit shows that the deprecation is working as intended! |
Hmm unfortunately due to how we handle warnings, this change will cause downstream crates to fail to compile (because we |
Hrmm, its only our repos that deny deprecated, perhaps other downstream users keep it at warn? (I'll update this repo for the change though) |
Description
Moves ark-ff::UniformRand to be a re-export of ark-std's version. Deprecates ark-ff::test_rng().
closes: #113
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer