Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add element(i: usize) to Domain trait #101

Merged
merged 6 commits into from
Nov 28, 2020
Merged

Add element(i: usize) to Domain trait #101

merged 6 commits into from
Nov 28, 2020

Conversation

ValarDragon
Copy link
Member

Description

Adds a function get_element(i) to the Domain trait, which returns the ith element of a domain. Such a method is useful in many applications, including STARKs.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests - Did not, I view this as sufficiently simple at the moment
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon requested a review from Pratyush November 28, 2020 02:22
CHANGELOG.md Outdated Show resolved Hide resolved
poly/src/domain/mod.rs Outdated Show resolved Hide resolved
poly/src/domain/radix2.rs Outdated Show resolved Hide resolved
poly/src/domain/mod.rs Outdated Show resolved Hide resolved
@Pratyush Pratyush changed the title Add get_element to Domain trait Add element(i: usize) to Domain trait Nov 28, 2020
@Pratyush Pratyush merged commit acf96b2 into master Nov 28, 2020
@Pratyush Pratyush deleted the get_element branch November 28, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants