Skip to content

Commit

Permalink
fix secrets/configmap updates do not trigger a controller reconcile (e…
Browse files Browse the repository at this point in the history
…nvoyproxy#3499)

* ensure both secrets and config map reconcile upon changes

ensure secret/config map changes trigger a reconcile

Signed-off-by: Alex Volchok <[email protected]>

* Update controller.go

Signed-off-by: Alex Volchok <[email protected]>

* Update controller.go

Signed-off-by: Alex Volchok <[email protected]>

---------

Signed-off-by: Alex Volchok <[email protected]>
(cherry picked from commit ff2c598)
Signed-off-by: Arko Dasgupta <[email protected]>
  • Loading branch information
alexwo authored and arkodg committed Jun 12, 2024
1 parent 41f9e37 commit 7bf1f48
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions internal/provider/kubernetes/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,6 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M

// Watch Secret CRUDs and process affected EG CRs (Gateway, SecurityPolicy, more in the future).
secretPredicates := []predicate.Predicate{
predicate.GenerationChangedPredicate{},
predicate.NewPredicateFuncs(r.validateSecretForReconcile),
}
if r.namespaceLabel != nil {
Expand All @@ -1123,7 +1122,6 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M

// Watch ConfigMap CRUDs and process affected ClienTraffiPolicies and BackendTLSPolicies.
configMapPredicates := []predicate.Predicate{
predicate.GenerationChangedPredicate{},
predicate.NewPredicateFuncs(r.validateConfigMapForReconcile),
}
if r.namespaceLabel != nil {
Expand Down

0 comments on commit 7bf1f48

Please sign in to comment.