Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders of western Anatolia #84

Conversation

Libeccio-DD
Copy link
Contributor

Changed the borders of all the provinces in the states Hudavendigar and Aydin as well as the provinces Eskishehir and Afyon to look closer to the historical borders of the administrative divisions of the Ottoman Empire. I plan on changing the borders of the rest of the Anatolian provinces but Eskishehir might prove a bit of a problem because the vast majority of the province's area was actually part of the the Ankara vilayet while the remaining left part which included the city Eskishehir belonged to the Hudavendigar.

https://en.wikipedia.org/wiki/Aidin_Vilayet
https://en.wikipedia.org/wiki/H%C3%BCdavendig%C3%A2r_Vilayet
https://en.wikipedia.org/wiki/Vilayet#/media/File:Rand,_McNally_&_Co.'s_new_14_x_21_map_of_Turkey_in_Asia,_Asia_Minor._Copyright_1895,_by_Rand,_McNally_&_Co._(Chicago,_1897).jpg

  • Comparison
    Before
    1
    After
    12

Copy link
Owner

@arkhometha arkhometha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Libeccio-DD, thanks for the pull.

It looks good. Do remember that provinces don't always need to correspond to their historical counterparts, there's quite a few exceptions. It's also good practice to avoid splitting terrain - have a province half inside mountains, half inside plains. It's not a problem here but since you mentioned you want to do a few more, keep that in mind please.

Unfortunately, I changed the map in Ghana and Ivory coast before accepting this commit, so I'm afraid there will be incompatibility. So I either need original map for this to apply the changes myself or you need to implement the changes of the latest version in this map/pull. Sorry about that.

@arkhometha
Copy link
Owner

arkhometha commented Feb 1, 2020

Correction: grab the latest development branch version, since cd12d7f introduced other map changes to Burma. Again, sorry about that.

Dumb me: I have access to your new map and it's easier for me to do it. I will take a look so I can merge it as soon as I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants