Declutter fixes for political, segregation, and return cores decisions #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the declutter system for the Natives'/African Diaspora Status, restoring AI/player parity by making either kind of country subject to the same restrictions (e.g. AI substates no longer can engage in those decisions). This should also prevent AI countries rapidly changing stances between e.g. assimilation and integration. This also takes care of multiple copy/paste mistakes in the African Diaspora code. Also included is a one-liner to make `change_border_policy` more like the de-clutter decision it is meant to be, by removing its restriction. No effect on gameplay. Minor related localisation fixes are included.
This change purely aims to improve tooltips. No effect on gameplay.
moretrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split in two commits, one useful one frivolous.
Political and Segregation Decisions
Improve the declutter system for the Natives'/African Diaspora Status,
restoring AI/player parity by making either kind of country subject to
the same restrictions (e.g. AI substates no longer can engage in those
decisions).
This should also prevent AI countries rapidly changing stances between
e.g. assimilation and integration.
This also takes care of multiple copy/paste mistakes in the African
Diaspora code.
Also included is a one-liner to make
change_border_policymore likethe de-clutter decision it is meant to be, by removing its restriction.
No effect on gameplay.
Minor related localisation fixes are included.
Return Cores Decisions
Purely a tooltip tweak.
I did not test this change in depth. I never observed the AI behaviour of successively adopting more than one segregation policy in actual gameplay either.