Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free_botswana and Lourenco Marques fixes #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cetvrtak
Copy link

@cetvrtak cetvrtak commented Dec 1, 2020

  1. Free Botswana decision - release_vassal = TSW requires them to be a vassal already to release from that status. Use
    release = TSW create_vassal = TSW

  2. #Getting Lourenço Marques event - although not an error, it would be better to scope to the state from a province already checked in the trigger - 2049 or 2050 instead of 2051

@moretrim
Copy link
Contributor

moretrim commented Dec 2, 2020

  1. Free Botswana decision - release_vassal = TSW requires them to be a vassal already to release from that status. Use
    release = TSW create_vassal = TSW

release_vassal has two functions:

  • it makes the non-existing argument country appear on the map, as if the country in scope had used the “Release Nation” button of the politics screen (it’s close enough anyway)
  • it breaks the vassal–puppet bond of the already existing argument country

Looking at the decision requirements it looks to me that the first role is intended here:

This seems entirely appropriate for creating a colonial puppet to me.

In contrast, release makes the argument country undergo the same process as during loading a new campaign, by reading from the history files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants